Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding test case for multiple forward slash case #4198

Merged

Conversation

apatruni
Copy link
Contributor

@apatruni apatruni commented Jan 18, 2025

What?

Adding another test case in TestTrimAferoPathSeparatorFs for the multiple consecutive file separator case

Why?

Checking an additional test case.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@apatruni apatruni requested a review from a team as a code owner January 18, 2025 16:40
@apatruni apatruni requested review from mstoykov and inancgumus and removed request for a team January 18, 2025 16:40
@CLAassistant
Copy link

CLAassistant commented Jan 18, 2025

CLA assistant check
All committers have signed the CLA.

@apatruni apatruni force-pushed the add-trimaferopathseparator-testcase branch from 28948eb to 431779a Compare January 18, 2025 16:57
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for this PR @apatruni

@apatruni
Copy link
Contributor Author

Thanks so much! I think once it has another approval i can merge

@apatruni
Copy link
Contributor Author

oh looks like i am not allowed to merge. please merge at your convenience. thank you!

@inancgumus inancgumus merged commit 46c37f5 into grafana:master Jan 22, 2025
27 of 28 checks passed
@inancgumus inancgumus added this to the v0.57.0 milestone Jan 28, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants